Minor Updates for EasyThreeD K7 #26145
Conversation
| ); | ||
| block->millimeters = get_move_distance(displacement OPTARG(HAS_ROTATIONAL_AXES, cartesian_move)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Well this obviously can't just be moved here, as most of the variables it references only exist in its original location. If the aim is to deal with block->steps[axis] having been affected by error_correction then it would be better to make a method that returns all the axis error_correction values or pre-update all the block->steps[] and then use the modified steps for the logic in Planner::_populate_block.
There was a problem hiding this comment.
My apologies, rookie git use, this wasn't supposed to end up in the PR, I expected the PR to be frozen not updated with the source.
I'll cancel this PR until I've finished working on the backlash issue
| @@ -142,7 +142,7 @@ void EasythreedUI::loadButton() { | |||
| } | |||
| else if (!flag) { | |||
| flag = true; | |||
| queue.inject(!READ(BTN_RETRACT) ? F("G91\nG0 E10 F180\nG0 E-120 F180\nM104 S0") : F("G91\nG0 E100 F120\nM104 S0")); | |||
| queue.inject(!READ(BTN_RETRACT) ? F("G91\nG0 E10 F180\nG0 E-220 F180\nM104 S0") : F("G91\nG0 E200 F120\nM104 S0")); | |||
There was a problem hiding this comment.
Is it possible to use this UI with other machines besides those which prefer these lengths?
|
@schmttc When you've got a solution to the backlash issue I'm happy to review it. I take it your intention is to submit a separate PR for that. |
|
@tombrazier Thanks, yes, will raise a separate PR for the backlash issue |
Description
Requirements
ET-4000+ Board
Configurations
configurations.zip
Related Issues
n/a