Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Pronto Integration (v2) #500

Closed
wants to merge 8 commits into from

Commits on Sep 8, 2020

  1. Pronto integration

    Integration of pronto required to add few new gems and to update some of
    the gems. The old method which provided the linter launching was
    reworked to launch pronto which provide the linter launching. The output
    of pronto is the result of all linters. The pronto result is transformed
    into a structure which match the original one. This integration required
    to change few tests and add new ones.
    
    Closes ManageIQ#192
    europ authored and NickLaMuro committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    aad33e6 View commit details
    Browse the repository at this point in the history
  2. No longer used files removed (lib/linter/)

    Request in ManageIQ#406 to remove files in lib/linter/ which are not used
    europ authored and NickLaMuro committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    b4cc189 View commit details
    Browse the repository at this point in the history
  3. Removed unused variable "inspected_file_count"

    Variable "inspected_file_count" in the result of the linters has been removed due to missing use. It was not used in the pull request comment describing the offenses detected by linters in the source code.
    europ authored and NickLaMuro committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    b7867fa View commit details
    Browse the repository at this point in the history
  4. Pronto linter dependencies automatically required

    Pronto runners (linters) expected to run will be automatically required in the CodeAnalysisMixin based on Gemfile specifications for pronto runners (linters).
    europ authored and NickLaMuro committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    a8d4051 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. [CodeAnalysisMixin] Simplify proto_result

    This makes use of the newly working (I hope) Repo#git_fetch, as well as
    removes some of the `mktmpdir` logic that shouldn't be required because
    we are using Rugged.
    NickLaMuro committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    a803e3a View commit details
    Browse the repository at this point in the history
  2. [CodeAnalysisMixin] Handle Rubocop errors

    This pulls back in some deleted code to handle errors with the Rubocop
    linter (but sets up a pattern for it moving forward).
    NickLaMuro committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    15428a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. [TESTING] Add manageiq-style

    Our configs for manageiq-ui-classic (which I am using for testing)
    require newer versions of Rubocop configs to function, so to facilitate
    the, I have included `manageiq-style` into this repo for testing this
    PR.  Might be required moving forward, but this is just for testing for
    now.
    NickLaMuro committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    8c70bca View commit details
    Browse the repository at this point in the history
  2. [WIP] Use up to date linter configs

    Right now, what ever is on the "fetched master" for the linter configs
    will be what is used by Pronto, and not what is up to date with the
    branch being checked against.
    
    This "attempts" to generate a config based on the git blob for the
    branch we are checking, but it is still not quite working.
    NickLaMuro committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    5331ffc View commit details
    Browse the repository at this point in the history