Rename remaining method calls to add_reviewer

ManageIQ · Mar 1, 2018 · 01b7dd0 · 01b7dd0
1 parent 665cb69
commit 01b7dd0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/github_service/commands/add_reviewer.rb b/lib/github_service/commands/add_reviewer.rb
@@ -7,7 +7,7 @@ def _execute(issuer:, value:)
         user = value.strip.delete('@')
 
         if valid_assignee?(user)
-          issue.review(user)
+          issue.add_reviewer(user)
         else
           issue.add_comment("@#{issuer} '#{user}' is an invalid reviewer, ignoring...")
         end

diff --git a/lib/github_service/issue.rb b/lib/github_service/issue.rb
@@ -10,7 +10,7 @@ def assign(user)
       GithubService.update_issue(fq_repo_name, number, "assignee" => user)
     end
 
-    def review(user)
+    def add_reviewer(user)
       GithubService.request_pull_request_review(fq_repo_name, number, [user]) if pull_request?
     end
 

diff --git a/...ib/github_service/commands/review_spec.rb → ...hub_service/commands/add_reviewer_spec.rb b/...ib/github_service/commands/review_spec.rb → ...hub_service/commands/add_reviewer_spec.rb
@@ -18,15 +18,15 @@
     let(:command_value) { "good_user" }
 
     it "review request that user" do
-      expect(issue).to receive(:review).with("good_user")
+      expect(issue).to receive(:add_reviewer).with("good_user")
     end
   end
 
   context "with an invalid user" do
     let(:command_value) { "bad_user" }
 
     it "does not review request, reports failure" do
-      expect(issue).not_to receive(:assign)
+      expect(issue).not_to receive(:add_reviewer)
       expect(issue).to receive(:add_comment).with("@#{command_issuer} 'bad_user' is an invalid reviewer, ignoring...")
     end
   end