Pin path-to-regexp #1925
Open
Pin path-to-regexp #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
Sep 16, 2024
| "nth-check": "^2.1.1" | ||
| "nth-check": "^2.1.1", | ||
| "express/path-to-regexp": "0.1.10", | ||
| "sinon": "~19.0.2" |
There was a problem hiding this comment.
Why do we need this resolution for sinon if we've updated the dependency?
There was a problem hiding this comment.
Bardjs uses sinon version 18 which doesn't use the latest version of path-to-regexp. So had to pin sinon to ensure the latest version is used for this.
Fryguy
reviewed
Sep 16, 2024
GilbertCherrie
force-pushed
the
update_path_to_regexp
branch
from
d7f7b91
to
4e5d951
Compare
|
Checked commit GilbertCherrie@4e5d951 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sinon to ~19.0.2 and pinned path-to-regexp to 0.1.10 to ensure we are using either the latest version of path-to-regexp or a version with patched vulnerabilities.