Fix non-unique keys error inside pf_aggregate_status_card #7295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please move it from draft to a PR? We usually don't do drafts, just prefix the PR title with |
skateman
suggested changes
Sep 8, 2020
|
Changes look good to me, can you please squash the two commits into a single one? |
llivne
force-pushed
the
liranl/SDE-1360_fix_non_unique_keys_bug_inside_pf_aggregate_status_card
branch
from
0536323
to
0e82aab
Compare
squashed :) |
skateman
reviewed
Sep 8, 2020
|
Looks great, can you squash the commits? There's no point in a 2 line PR to have 2 commits. |
Update app/javascript/components/pf_aggregate_status_card.jsx Co-authored-by: Halász Dávid <[email protected]> Update app/javascript/components/pf_aggregate_status_card.jsx Co-authored-by: Halász Dávid <[email protected]>
llivne
force-pushed
the
liranl/SDE-1360_fix_non_unique_keys_bug_inside_pf_aggregate_status_card
branch
from
47b3b31
to
9f1008f
Compare
|
Checked commit Autosde@9f1008f with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following warning raised once we tried to implement new features that use the generic PfAggregateStatusCard.
Warning: Encountered two children with the same key,
%s. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.%s,[object Object], in p (created by PfAggregateStatusCard) in div (created by PfAggregateStatusCard) in div (created by PfAggregateStatusCard) in PfAggregateStatusCard (created by AggregateStatusCard) in div (created by AggregateStatusCard) in div (created by AggregateStatusCard) in AggregateStatusCard in ProviderThe error is because key={notification} returns string of notification with the value of object, and therefore for several objects we get the same key. we therefore suggest to change the key to the map index which is unique.