Keep track of when people where recorded as owners #59

Makespace · Sep 5, 2024 · bcc2fc2 · bcc2fc2
1 parent 3a48c71
commit bcc2fc2
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 3 deletions.
diff --git a/src/read-models/shared-state/get-member.ts b/src/read-models/shared-state/get-member.ts
@@ -43,6 +43,7 @@ export const getMember =
         .select({
           id: ownersTable.areaId,
           name: areasTable.name,
+          ownershipRecordedAt: ownersTable.ownershipRecordedAt,
         })
         .from(ownersTable)
         .leftJoin(areasTable, eq(areasTable.id, ownersTable.areaId))

diff --git a/src/read-models/shared-state/return-types.ts b/src/read-models/shared-state/return-types.ts
@@ -17,6 +17,7 @@ type TrainedOn = {
 type OwnerOf = {
   id: string;
   name: string;
+  ownershipRecordedAt: Date;
 };
 
 export type Member = {

diff --git a/src/read-models/shared-state/state.ts b/src/read-models/shared-state/state.ts
@@ -102,12 +102,16 @@ export const ownersTable = sqliteTable('owners', {
   areaId: text('areaId')
     .notNull()
     .references(() => areasTable.id),
+  ownershipRecordedAt: blob('ownershipRecordedAt', {mode: 'json'})
+    .notNull()
+    .$type<Date>(),
 });
 
 const createOwnersTable = sql`
   CREATE TABLE IF NOT EXISTS owners (
     memberNumber INTEGER,
-    areaId TEXT
+    areaId TEXT,
+    ownershipRecordedAt BLOB
   )
 `;
 

diff --git a/src/read-models/shared-state/update-state.ts b/src/read-models/shared-state/update-state.ts
@@ -105,7 +105,11 @@ export const updateState =
         break;
       case 'OwnerAdded':
         db.insert(ownersTable)
-          .values({memberNumber: event.memberNumber, areaId: event.areaId})
+          .values({
+            memberNumber: event.memberNumber,
+            areaId: event.areaId,
+            ownershipRecordedAt: event.recordedAt,
+          })
           .run();
         break;
 

diff --git a/tests/read-models/shared-state/get-member.test.ts b/tests/read-models/shared-state/get-member.test.ts
@@ -221,8 +221,11 @@ describe('get-via-shared-read-model', () => {
         name: faker.company.buzzNoun() as NonEmptyString,
         id: faker.string.uuid() as UUID,
       };
+      const recordedAt = faker.date.future();
+      recordedAt.setMilliseconds(0);
       beforeEach(async () => {
         await framework.commands.area.create(createArea);
+        advanceTo(recordedAt);
         await framework.commands.area.addOwner({
           memberNumber: memberNumber,
           areaId: createArea.id,
@@ -236,7 +239,12 @@ describe('get-via-shared-read-model', () => {
         expect(result.ownerOf[0].name).toStrictEqual(createArea.name);
       });
 
-      it.todo('returns when they became an owner');
+      it('returns when they became an owner', () => {
+        const result = runQuery();
+        expect(result.ownerOf[0].ownershipRecordedAt).toStrictEqual(
+          recordedAt.toISOString()
+        );
+      });
     });
   });
 });