Remove deprecated refresh of read model #59

Makespace · Aug 7, 2024 · 95869aa · 95869aa
1 parent 25865ea
commit 95869aa
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 19 deletions.
diff --git a/src/queries/me/construct-view-model.ts b/src/queries/me/construct-view-model.ts
@@ -11,14 +11,13 @@ import {ViewModel} from './view-model';
 import {StatusCodes} from 'http-status-codes';
 import {sequenceS} from 'fp-ts/lib/Apply';
 import {readModels} from '../../read-models';
-import * as IO from 'fp-ts/IO';
 
 export const constructViewModel =
   (deps: Dependencies, user: User) =>
   (memberNumber: number): TE.TaskEither<FailureWithStatus, ViewModel> =>
     pipe(
       deps.getAllEvents(),
-      TE.tapIO(events => IO.of(deps.sharedReadModel.refresh(events))),
+      TE.tapTask(() => deps.sharedReadModel.asyncRefresh()),
       TE.map(events => ({
         user: E.right(user),
         isSelf: E.right(memberNumber === user.memberNumber),

diff --git a/src/read-models/shared-state/index.ts b/src/read-models/shared-state/index.ts
@@ -111,7 +111,6 @@ export const updateState =
 export type SharedReadModel = {
   db: BetterSQLite3Database;
   asyncRefresh: () => T.Task<void>;
-  refresh: (events: ReadonlyArray<DomainEvent>) => void;
   members: {
     get: (memberNumber: number) => O.Option<Member>;
   };
@@ -123,23 +122,11 @@ export type SharedReadModel = {
 export const initSharedReadModel = (
   eventStoreClient: Client
 ): SharedReadModel => {
-  let knownEvents = 0;
   const readModelDb = drizzle(new Database());
   createTables.forEach(statement => readModelDb.run(statement));
   return {
     db: readModelDb,
     asyncRefresh: asyncRefresh(eventStoreClient, updateState(readModelDb)),
-    refresh: events => {
-      if (knownEvents === events.length) {
-        return;
-      }
-      if (knownEvents === 0) {
-        knownEvents = events.length;
-        events.forEach(updateState(readModelDb));
-        return;
-      }
-      knownEvents = events.length;
-    },
     members: {
       get: getMember(readModelDb),
     },

diff --git a/tests/read-models/shared-state/get-equipment.test.ts b/tests/read-models/shared-state/get-equipment.test.ts
@@ -11,8 +11,7 @@ describe('get', () => {
   let framework: TestFramework;
   const equipmentId = faker.string.uuid() as UUID;
   const runQuery = async () => {
-    const events = await framework.getAllEvents();
-    framework.sharedReadModel.refresh(events);
+    await framework.sharedReadModel.asyncRefresh()();
     return pipe(
       equipmentId,
       framework.sharedReadModel.equipment.get,

diff --git a/tests/read-models/shared-state/get-member.test.ts b/tests/read-models/shared-state/get-member.test.ts
@@ -18,8 +18,7 @@ describe('get-via-shared-read-model', () => {
   const memberNumber = faker.number.int();
   const otherMemberNumber = faker.number.int();
   const runQuery = async (id = memberNumber) => {
-    const events = await framework.getAllEvents();
-    framework.sharedReadModel.refresh(events);
+    await framework.sharedReadModel.asyncRefresh()();
     return pipe(id, framework.sharedReadModel.members.get, getSomeOrFail);
   };