Fix non-runtime dependencies #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YiLiu6240
approved these changes
Jul 7, 2024
|
Yi if you're happy with this you need to merge this then send the new release to CRAN (because in the linked issue the styler developer is asking for your CRAN version to be updated). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Yi
I've had a look, as per issue #7 you had quite a few non-runtime dependencies declared in your DESCRIPTION. I think I've fixed them all. I've also updated your 2 GitHub Actions workflows.
Happy to have a chat about this if helpful.
Fixes #7
(Also I spot the UoB and IEU logo files that you use in the README need updating.)
All the best
Tom