Hd codes/issue4655 #4702
Hd codes/issue4655 #4702
Conversation
- Added necessary imports to `__all__` to ensure they are part of the public API and avoid F401 warnings. - Removed unnecessary imports that were not being used in the code. - Moved logger initialization to after imports, ensuring compliance with PEP 8 guidelines and resolving F821 (undefined logger) error. - Ensured that all module-level imports remain at the top of the file as per PEP 8 to avoid E402 errors. This commit cleans up the codebase to resolve Ruff linter warnings and ensures better readability and compliance with Python best practices.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
Linter Bot Results:Hi @HD-Codes! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
- Reformatted long lines to comply with the 88-character limit (E501). - Removed trailing whitespace from lines (W291). - Updated the `__all__` list for better readability and code style compliance. - Adjusted the logger and import formatting to improve code organization. This commit resolves the issues raised by the Linter Bot and ensures that the code adheres to PEP 8 standards.
|
Hello @HD-Codes , thanks for your contribution. I don't see where you're addressing #4655 in your PR. Can you please point it out? The current PR proposes code clean-up in |
Fixes #4655
Changes made in this Pull Request:
package\MDAnalysis\__init__.pyto avoid potential bugs.package\MDAnalysis\__init__.pyto comply with PEP 8 guidelines.package\MDAnalysis\__init__.pyand added relevant ones to__all__for better code organization and adherence to public API conventions.PR Checklist
Developers certificate of origin