Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Cif reader #4681

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

[WIP] Cif reader #4681

wants to merge 12 commits into from

Conversation

hp115
Copy link
Contributor

@hp115 hp115 commented Aug 23, 2024

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4681.org.readthedocs.build/en/4681/

@pep8speaks
Copy link

pep8speaks commented Aug 23, 2024

Hello @hp115! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 29:80: E501 line too long (98 > 79 characters)
Line 30:80: E501 line too long (113 > 79 characters)
Line 44:1: E303 too many blank lines (4)
Line 65:80: E501 line too long (80 > 79 characters)
Line 79:1: W293 blank line contains whitespace
Line 80:5: E303 too many blank lines (3)
Line 89:1: W391 blank line at end of file

Line 28:80: E501 line too long (98 > 79 characters)
Line 29:80: E501 line too long (113 > 79 characters)
Line 47:5: E303 too many blank lines (2)
Line 57:80: E501 line too long (80 > 79 characters)
Line 61:37: E128 continuation line under-indented for visual indent
Line 61:80: E501 line too long (80 > 79 characters)
Line 69:9: E731 do not assign a lambda expression, use a def
Line 73:80: E501 line too long (81 > 79 characters)
Line 74:13: E731 do not assign a lambda expression, use a def
Line 101:1: W391 blank line at end of file

Line 102:13: E122 continuation line missing indentation or outdented
Line 103:9: E122 continuation line missing indentation or outdented

Line 1:14: W291 trailing whitespace
Line 6:1: E303 too many blank lines (3)
Line 8:1: E302 expected 2 blank lines, found 1
Line 8:10: W292 no newline at end of file

Comment last updated at 2024-08-23 15:11:23 UTC

Copy link

github-actions bot commented Aug 23, 2024

Linter Bot Results:

Hi @hp115! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ⚠️ Possible failure

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/10528066841/job/29172710356


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants