Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup/UI #3

Merged
merged 8 commits into from
Aug 11, 2023
Merged

Setup/UI #3

merged 8 commits into from
Aug 11, 2023

Conversation

M-AminAlizadeh
Copy link
Owner

The Things that I did in this PR:

  • Try to build UI using JSX
  • Use Grid for layout

Copy link

@topeogunleye topeogunleye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M-AminAlizadeh,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

dwayne-the-rock

(Highlights) Good Points: 💪

🎉 Great job on fulfilling the project requirements!
🎨 The project structure is well-organized with a clear separation of components.
🧮 You've successfully implemented a functional component for the Calculator.

Areas of Excellence:
👍 The boilerplate code from CRA has been properly removed.
👏 The Calculator.js file is correctly placed inside the components directory.
🧩 You've successfully created a functional component for the Calculator, following the provided design guidelines.
🔧 Added child components to the Calculator.js component to enhance functionality and modularity.

Overall, your project demonstrates a strong understanding of the React framework and component-based architecture. Keep up the good work and continue building on your skills. Well done! 👏👨‍💻👩‍💻

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

You can also consider:

  • Nothing to mention

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag @topeogunleye in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@M-AminAlizadeh M-AminAlizadeh merged commit 8a3ff39 into dev Aug 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants