New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: type narrow types with literal fields #2864

Open

lewis6991 wants to merge 1 commit into LuaLS:master from lewis6991:feat/narrowlit

+110 −0

Contributor

lewis6991 commented Sep 22, 2024 •

edited

Loading

---@class A
---@field type 'a'

---@class B
---@field type 'b'

local obj --- @type A|B

if obj.type == 'a' then
    -- obj is narrowed to type A
end

Currently only narrows types defined with @class. I attempted to make this work for @alias (as in #704) but it got rather complicated.

It may be beneficial to cache the result of getNodeTypesWithLiteralField.


          feat: type narrow types with literal fields

5c3086a

lewis6991 marked this pull request as ready for review

September 22, 2024 16:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet