Add setting to find globals using regex #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve checkIsUndefinedGlobal to avoid unecessary checks and tables
emmericp
added a commit
to emmericp/DBM-Retail
that referenced
this pull request
Apr 26, 2024
By default LuaLS allows us to implictly declare a global by writing to it, whereas LuaCheck didn't allow this. Since we don't want to write to many globals it's better to require them to be explicitly declared in .luarc.json. Unlike LuaCheck this unfortunately doesn't support regular expressions to define the set of allowed globals, this will be fixed in LuaLS/lua-language-server#2629 soon hopefully.
emmericp
added a commit
to emmericp/DBM-Retail
that referenced
this pull request
Apr 26, 2024
By default LuaLS allows us to implictly declare a global by writing to it, whereas LuaCheck didn't allow this. Since we don't want to write to many globals it's better to require them to be explicitly declared in .luarc.json. Unlike LuaCheck this unfortunately doesn't support regular expressions to define the set of allowed globals, this will be fixed in LuaLS/lua-language-server#2629 soon hopefully.
emmericp
added a commit
to DeadlyBossMods/DeadlyBossMods
that referenced
this pull request
Apr 26, 2024
By default LuaLS allows us to implictly declare a global by writing to it, whereas LuaCheck didn't allow this. Since we don't want to write to many globals it's better to require them to be explicitly declared in .luarc.json. Unlike LuaCheck this unfortunately doesn't support regular expressions to define the set of allowed globals, this will be fixed in LuaLS/lua-language-server#2629 soon hopefully.
|
Nice work, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use the LuaLS for many years and all of these years I had disabled the undefined-global because my project use global envs, and in these envs I have some globals like "const_something" and "SOMETHING" in more than 1000 submodules. So I needed this feature to improve my project checking.
I also improved to avoid unecessary checks in checkIsUndefinedGlobal like create a table with all elements to check only one of them.
This is related to: #2627
Exemple of config: