Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update string.dump so it doesn't have strip argument in Lua 5.1 and 5.2 #2225

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Update string.dump so it doesn't have strip argument in Lua 5.1 and 5.2 #2225

merged 1 commit into from
Jul 27, 2023

Conversation

C3pa
Copy link
Contributor

@C3pa C3pa commented Jul 26, 2023

Fixes #2224. I hope I figured out the syntax used in these templates correctly.

Note:

  • LuaJIT also includes the strip argument for string.dump.

@sumneko
Copy link
Collaborator

sumneko commented Jul 27, 2023

Thank you!

@sumneko sumneko merged commit a9adf80 into LuaLS:master Jul 27, 2023
7 checks passed
@C3pa C3pa deleted the update-string-annotations branch January 10, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lua 5.1 and 5.2 shouldn't have second argument in string.dump annotations
2 participants
@C3pa @sumneko