Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing guide #35

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Contributing guide #35

wants to merge 6 commits into from

Conversation

C3pa
Copy link

@C3pa C3pa commented Apr 27, 2024

This is the initial draft of the contributing guide. I am open to any suggestions. Also, I left the Allow edits by maintainers checked, @carsakiller can directly commit to this PR if needed. The Wiki contains a nice amount of info on contributing to all of the areas of LLS, so this article is mostly an overview with links. I didn't write anything about the code style. I think that article would best be written by Sumneko. We can start a discussion about that.

I removed the getting-started flag from the Build article since I think the new article is meant to be the central getting started at contributing article.

Note: I haven't yet interacted with .mdx files, I hope I got everything right. Currently, everything is styled just with regular markdown.

Once the project has a central contributing article, I am planning to add a link to the guide from: https://github.com/LuaLS/lua-language-server/blob/master/README.md

@carsakiller carsakiller added help wanted Extra attention is needed wiki/authoring Adds new content to the website labels Apr 28, 2024
@carsakiller
Copy link
Collaborator

I have pushed quite a few changes. Let me know what you think. I think the developing page could use a lot of work. I don't know enough about developing the language server to really improve it, though, I just know it isn't very helpful for getting a beginner contributor up to speed on the project.

@C3pa
Copy link
Author

C3pa commented Apr 28, 2024

I have pushed quite a few changes. Let me know what you think

Thanks for these! I think all of these are an objective improvement.

I think the developing page could use a lot of work. I don't know enough about developing the language server to really improve it, though, I just know it isn't very helpful for getting a beginner contributor up to speed on the project.

I totally agree. Unfortunately, the people who know the inner workings of language server are few and far between. I think we could open an issue at the main repository to bring the issue to more eyes, so hopefully that gets improved at one point.

@carsakiller
Copy link
Collaborator

@sumneko would you be able to provide some more insight into how you develop the language server? I think I recall you saying that development is primarily test-driven. However, I'm not sure how the testing framework works — I believe it is custom? Some pointers on writing and running tests would be appreciated!

Is there a specific flow/method you would recommend for contributors? For the few simple things I have contributed, I have just used print() as described in this PR — but I don't think it would be very efficient for larger changes.

I think creating good documentation here for developing the language server would greatly help the community make some really nice pull requests. I've seen many comments from users eager to help but confused when getting their development environment set up and navigating the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed wiki/authoring Adds new content to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants