feat: add display timezone switcher, remove local timezone toggle #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziinc
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in local timezone display switching, which provides better ux when users want to switch their display timezone while keeping the search tied to a different timezone.
It forces a differentiation between "search timezone" and "display timezone", where display timezone only changes the displayed timezone, whereas search timezone will affect the search queries that the user will query in.
Adjustments to the search timezone button and moving it closer to the form will come in a follow up PR.
Screen.Recording.2024-06-10.at.9.09.18.PM.mov
Also added in a UTC convenience button
Screen.Recording.2024-06-10.at.9.19.35.PM.mov