Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script for user with Py3+ #321

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JackSparrow0723
Copy link

Update for use with Py3+
Changes


  1. Change raw_input -> input -- raw_input is not supported on python3+.
  2. Add Parenthesisis on line 8 for user print.

@JackSparrow0723 JackSparrow0723 changed the title Py3+ Update - Update script for user with Py3+ Jun 3, 2022
@JackSparrow0723 JackSparrow0723 changed the title Update - Update script for user with Py3+ Update script for user with Py3+ Jun 3, 2022
@nathmo
Copy link

nathmo commented Jul 8, 2022

Hey thats neet. Do you mind if i apply thoses change on my fork ? I needed to switch to python 3 too

@tarciziovn
Copy link

I tried to run the Katoolin master version on my computer and it doesn't work due to the Python version problem. My computer only has Python v3 installed, so I thought that would be the worst decision to install old version of Python only to run Katoolin. I changed the code for compatibility with Python 3. So when I come to pull requests to suggest this change on the Katoolin code, I noticed that there are at least other two pull requests solving this compatibility problem with at least more than 6 months opened! Until now the maintainers did not consider applying those fixes! Why have those simple changes weren't been applied to the master version?
I considered the possibility that the maintainer had died...
Will we have to create a fork version to apply those important changes?

@tarciziovn
Copy link

tarciziovn commented Aug 1, 2023

@JackSparrow0723 I noticed that has passed more than 1 year of this pull request and those important fixes wasn't been applied. It seems that this project is abandoned. So, I decided to create a fork version of this project for receiving all fixes and improvements... if the maintainer in near future decides to bring the changes, its ok, but until this would be better for community work under a new fork that I created of this project:
https://github.com/tarciziovn/katoolin

@tarciziovn
Copy link

Update for use with Py3+ Changes

  1. Change raw_input -> input -- raw_input is not supported on python3+.
  2. Add Parenthesisis on line 8 for user print.

I applied your suggestion of parenthesis to my own fok of the project, but I'm using other suggestion of using the lib past.builtins importing raw_input function for compatibility on Python 2 and 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants