lkft-android: devices: some improvments from comments for other PR #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set default or drop default as commented here: Linaro#259 Signed-off-by: Yongqin Liu <[email protected]>
liuyq
force-pushed
the
android-upstream-devices
branch
from
121ab4c
to
75a4ebc
Compare
drop the uncessary } after %}, but it seems do not cause problem on the generation Fixes: 249db05 ("lkft-android: add support for hikey960 device") Fixes: a0df0f6 ("lkft-android: add support for qrb5165-rb5 device") Signed-off-by: Yongqin Liu <[email protected]>
liuyq
force-pushed
the
android-upstream-devices
branch
from
75a4ebc
to
f18254a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dropping the default or adding default for some variables definition
and fix the syntax for endline of "%}}"