Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit_for_testing: use qa_server_group and not _team #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roxell
Copy link
Collaborator

@roxell roxell commented Aug 31, 2020

It is a group setting on the qa-reports web page and not a team.

Signed-off-by: Anders Roxell [email protected]

@mwasilew
Copy link
Contributor

mwasilew commented Sep 3, 2020

IMHO group and team tare the same thing in this context.

@mwasilew
Copy link
Contributor

mwasilew commented Sep 3, 2020

The only failure in testing is on python file formatting. Please run black and commit changes. This should fix the sanity job.

@mwasilew
Copy link
Contributor

mwasilew commented Sep 3, 2020

I think we should preserve backward compatibility. So both --qa-server-team and --qa-server-group should set the same variable. Later we'll need a new patch that will throw an exception when someone tries to use --qa-server-team.

It is a group setting on the qa-reports web page and not a team.

Signed-off-by: Anders Roxell <[email protected]>
@jscook2345
Copy link
Contributor

@roxell

I think this looks good, but since we're deprecating the use of the option, can we log or print a warning when the argument is set?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants