Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Use cookiecutter organization name throughout project #656

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

melissafelch
Copy link
Contributor

@melissafelch melissafelch commented Sep 21, 2023

Short description

This pull request builds on work started in PR #280 to utilize org_name and other cookiecutter variables throughout the project. Because cookiecutter uses jinja templating to generate its files, we have created a unique string for blocks and variables which allows internal templating to be ignored as files are processed. This allows us to collect and insert information gathered from cookiecutter prompts.

Any point in the PR you think needs extra attention

In order to use this, please be sure to update cookiecutter to at least v 2.3.0. Otherwise, things will break spectacularly!

I initially missed some files involved in migrations because they were omitted from vscode's search function. While I combed for any instances where cookiecutter was used, there is also a possibility that I may have missed perfectly valid jinja inside files which were not templated. I believe I caught them all but a critical eye would be appreciated!

New Features or Fixes

  1. Header and footers now utilize cookiecutter for project and organization
  2. Default emails are now generated based on domain name, not organization name.
  3. find & replace and find & replace and find & replace and find & replace and find & replace and find & replace and

Video of feature working

Screen.Recording.2023-09-21.at.3.39.10.PM.mov
Screenshot 2023-09-21 at 3 41 55 PM

@melissafelch melissafelch changed the title Feature/cookie cutter jinja Feature/Use cookiecutter organization name throughout project Sep 21, 2023
MODULE_REGEX = r"^[a-z][_a-z]+$"

module_name = "{{cookiecutter.repo_name}}"
module_name = "{{ cookiecutter.repo_name }}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weirdly enough, this file ignores the _jinja2_env_vars for strings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants