Implement channel rename #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, chathistory still matches based on channel name, so it's not carried over to the new channel.
spb
reviewed
Sep 17, 2023
| @@ -32,6 +32,7 @@ pub enum ChannelAccessFlag { | |||
| ReceiveOp = 0x0000_0010, | |||
| ReceiveVoice = 0x0000_0020, | |||
| ReceiveOpmod = 0x0000_0040, | |||
| Rename = 0x0000_0080, | |||
There was a problem hiding this comment.
This isn't a receive statusmsg flag, it's a take action flag, so it belongs in the next group with topic/kick
There was a problem hiding this comment.
the next group doesn't have room for another bit
There was a problem hiding this comment.
0x0000_1000 to 0x0000_8000 are available and fit in at the end of the next group
| @@ -250,7 +250,9 @@ impl SendHistoryItem for update::ChannelInvite { | |||
|
|
|||
| impl SendHistoryItem for update::ChannelRename { | |||
| fn send_to(&self, _conn: impl MessageSink, _from_entry: &HistoryLogEntry) -> HandleResult { | |||
| todo!(); | |||
| // Not part of history, so it is handled entirely in send_realtime.rs. | |||
| // See https://github.com/ircv3/ircv3-specifications/issues/532 | |||
There was a problem hiding this comment.
That issue seems to say it should be part of history, though.
There was a problem hiding this comment.
it's undecided for now so I'm mirroring existing implementations
configs/network_config.json
Outdated
| @@ -34,6 +34,7 @@ | |||
| "quiet_view", "quiet_add", "quiet_remove_any", | |||
| "exempt_view", "exempt_add", "exempt_remove_any", | |||
| "invite_self", "invite_other", | |||
| "rename", | |||
There was a problem hiding this comment.
This belongs better between lines 32-33. It also needs to be reflected in the default services config's default roles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I triggered the
todo!();because of channel name clashes so I wanted to fix it; and it's easier to test the code when clients can explicitly ask for renames.For now, chathistory still matches based on channel name, so it's not carried over to the new channel. We need to discuss in ircv3/ircv3-specifications#532 what exactly it should look like to clients.