Return ERR_INPUTTOOLONG instead of closing connection on messages longer than ~1020 bytes #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger than ~1020 bytes As recommended by https://ircv3.net/specs/extensions/message-tags#size-limit
|
Does this continue to eat the rest of the input on too long until a new line character shows up to terminate the line? |
|
yes. and actually I think there's a way to DoS sable here, because it looks like |
|
There is a DoS there, yes - client_listener is still basically a proof of concept to let the rest of the ircd work; it needs reworking at some point for that and several other reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended by https://ircv3.net/specs/extensions/message-tags#size-limit