Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speculos: Fasten graphics handling #457

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

xchapron-ledger
Copy link
Contributor

This changes allow to reduce app-boilerplate stax tests run time from 50s to 18s on my setup.
Note that this could be further reduced to 10s if using ragger configuration BACKEND_SCOPE="session".

@xchapron-ledger xchapron-ledger force-pushed the xch/faster-graphics branch 2 times, most recently from 3dd4b0a to 01f83fa Compare February 23, 2024 13:25
This changes allow to reduce app-boilerplate stax tests run time from
50s to 18s on my setup.
Note that this could be further reduced to 10s if using ragger
configuration BACKEND_SCOPE="session".
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 16.43836% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 45.25%. Comparing base (3a3439f) to head (a841439).

Files Patch % Lines
speculos/mcu/display.py 20.00% 32 Missing ⚠️
speculos/mcu/vnc.py 0.00% 16 Missing ⚠️
speculos/mcu/nbgl.py 44.44% 5 Missing ⚠️
speculos/mcu/screen.py 0.00% 5 Missing ⚠️
speculos/mcu/headless.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
- Coverage   45.26%   45.25%   -0.01%     
==========================================
  Files         120      120              
  Lines       11928    11940      +12     
  Branches      957      957              
==========================================
+ Hits         5399     5404       +5     
- Misses       6194     6201       +7     
  Partials      335      335              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xchapron-ledger xchapron-ledger merged commit f558c92 into master Feb 26, 2024
25 checks passed
@xchapron-ledger xchapron-ledger deleted the xch/faster-graphics branch February 26, 2024 09:33
Copy link
Contributor

@lpascal-ledger lpascal-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement !

speculos/mcu/display.py Show resolved Hide resolved
speculos/mcu/vnc.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants