Merge pull request #18 from LedgerHQ/manifest

[add] manifest

.github/workflows/build_tests_and_analysis.yml

@@ -22,7 +22,6 @@ jobs:
     uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_ragger_tests.yml@v1
     with:
       download_app_binaries_artifact: compiled_app_binaries
-      test_dir: tests/functional
       run_for_devices: '["stax"]'
 
   unittesting:

Makefile

@@ -43,7 +43,6 @@ endif
 
 # Build configuration
 
-DEFINES += APPNAME=\"$(APPNAME)\"
 DEFINES += APPVERSION=\"$(APPVERSION)\"
 DEFINES += LEDGER_MAJOR_VERSION=$(APPVERSION_M)
 DEFINES += LEDGER_MINOR_VERSION=$(APPVERSION_N)

ledger_app.toml

@@ -0,0 +1,8 @@
+[app]
+build_directory = "./"
+sdk = "C"
+devices = ["nanos", "nanox", "nanos+", "stax"]
+
+[tests]
+unit_directory = "./tests/unit"
+pytest_directory = "./tests/functional"

src/nano/nanos_enter_phrase.c

@@ -16,6 +16,7 @@
 
 #include <os_io_seproxyhal.h>
 #include <lcx_hmac.h>
+#include <ledger_assert.h>
 
 #include "constants.h"
 #include "glyphs.h"
@@ -229,8 +230,10 @@ void compare_recovery_phrase(void) {
     cx_hmac_sha512_t ctx;
     const char key[] = "Bitcoin seed";
 
-    cx_hmac_sha512_init_no_throw(&ctx, (const uint8_t*) key, strlen(key));
-    cx_hmac_no_throw((cx_hmac_t*) &ctx, CX_LAST, buffer, 64, buffer, 64);
+    LEDGER_ASSERT(cx_hmac_sha512_init_no_throw(&ctx, (const uint8_t*) key, strlen(key)) == CX_OK,
+                  "HMAC init failed");
+    LEDGER_ASSERT(cx_hmac_no_throw((cx_hmac_t*) &ctx, CX_LAST, buffer, 64, buffer, 64) == CX_OK,
+                  "HMAC failed");
     PRINTF("Root key from input:\n%.*H\n", 64, buffer);
 
     // get rootkey from device's seed

src/nano/nanox_enter_phrase.c

@@ -16,6 +16,7 @@
 
 #include <lcx_hmac.h>
 #include <lcx_rng.h>
+#include <ledger_assert.h>
 
 #include "../constants.h"
 #include "../ui.h"
@@ -410,8 +411,10 @@ static uint8_t compare_recovery_phrase(void) {
     cx_hmac_sha512_t ctx;
     const char key[] = "Bitcoin seed";
 
-    cx_hmac_sha512_init_no_throw(&ctx, (const uint8_t*) key, strlen(key));
-    cx_hmac_no_throw((cx_hmac_t*) &ctx, CX_LAST, buffer, 64, buffer, 64);
+    LEDGER_ASSERT(cx_hmac_sha512_init_no_throw(&ctx, (const uint8_t*) key, strlen(key)) == CX_OK,
+                  "HMAC init failed");
+    LEDGER_ASSERT(cx_hmac_no_throw((cx_hmac_t*) &ctx, CX_LAST, buffer, 64, buffer, 64) == CX_OK,
+                  "HMAC failed");
     PRINTF("Root key from input:\n%.*H\n", 64, buffer);
 
     // get rootkey from device's seed