[fix] os_derive_bip32 syscall can't take NULL path

LedgerHQ · Nov 13, 2023 · 80838af · 80838af
1 parent 504aed6
commit 80838af
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/nano/nanos_enter_phrase.c b/src/nano/nanos_enter_phrase.c
@@ -236,7 +236,9 @@ void compare_recovery_phrase(void) {
     // get rootkey from device's seed
     uint8_t buffer_device[64];
 
-    if (os_derive_bip32_no_throw(CX_CURVE_256K1, NULL, 0, buffer_device, buffer_device + 32) !=
+    // os_derive_bip32* do not accept NULL path, even with a size of 0, so we provide an empty path
+    const unsigned int empty_path = 0;
+    if (os_derive_bip32_no_throw(CX_CURVE_256K1, &empty_path, 0, buffer_device, buffer_device + 32) !=
         CX_OK) {
         PRINTF("An error occurred while comparing the recovery phrase\n");
         return;

diff --git a/src/nano/nanox_enter_phrase.c b/src/nano/nanox_enter_phrase.c
@@ -417,7 +417,9 @@ static uint8_t compare_recovery_phrase(void) {
     // get rootkey from device's seed
     uint8_t buffer_device[64];
 
-    if (os_derive_bip32_no_throw(CX_CURVE_256K1, NULL, 0, buffer_device, buffer_device + 32) !=
+    // os_derive_bip32* do not accept NULL path, even with a size of 0, so we provide an empty path
+    const unsigned int empty_path = 0;
+    if (os_derive_bip32_no_throw(CX_CURVE_256K1, &empty_path, 0, buffer_device, buffer_device + 32) !=
         CX_OK) {
         PRINTF("An error occurred while comparing the recovery phrase\n");
         return 0;