Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes for chapters 6, 7 and 8 #109

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Minor fixes for chapters 6, 7 and 8 #109

wants to merge 20 commits into from

Commits on Jun 26, 2024

  1. fix usage of W_5 in ex. 132 (L_QAP(R3.fac_zk)) 

    It should be W_4, same as in the previous (referenced) examples.
    @Vindaar
    Vindaar committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a46c329 View commit details
    Browse the repository at this point in the history

  2. use \text{Malbolge} for Malbolge 'language'

    @Vindaar
    Vindaar committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c2bc7d1 View commit details
    Browse the repository at this point in the history

  3. wrap lagrange polynomial calc in \left( \right) parens

    @Vindaar
    Vindaar committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c040f5d View commit details
    Browse the repository at this point in the history

  4. [circom] input signals are always private, cannot be marked as such 

    As far as I understand in the JS 'Circom 1' this was supported. But at
this point, I suppose it's more sensible to have code that is valid
for Circom 2.
    @Vindaar
    Vindaar committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4ff96b2 View commit details
    Browse the repository at this point in the history

  5. fix labels in example circuits 

    Instance variables and witness variables in the previous part always
individually start from index 1. This rule is broken in the first
fixed circuit.

In the second one this is also broken and in addition in the
simplified circuit we should rename the witnesses to go from 1 to 3
instead of having {1, 3, 4}.
    @Vindaar
    Vindaar committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1870943 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. minor syntax fixes in PAPER fn AND, NOT

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    58cd170 View commit details
    Browse the repository at this point in the history

  2. fix I_5 -> I_1 for prover example

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    ec4436f View commit details
    Browse the repository at this point in the history

  3. fix m -> m-1 indices in binary field reps 

    Note: I also changed the

0 \leq j < m

to

0 \leq j \leq m

because I first didn't realize the second operator was not a less than
equal, but a real less than.
    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    e67e7ca View commit details
    Browse the repository at this point in the history

  4. [groth16] use curly braces for parameter sets

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    895f7a2 View commit details
    Browse the repository at this point in the history

  5. add missing space

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    79deb5a View commit details
    Browse the repository at this point in the history

  6. add missing example label (3-fac CRS), fix reference to equation

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1e07645 View commit details
    Browse the repository at this point in the history

  7. add labels to [A2]g_1, [A5]g_1 3-fac example, reference for clarity

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b1108b7 View commit details
    Browse the repository at this point in the history

  8. [groth16] add labels to prover / verifier eqs, ref them

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9c0991f View commit details
    Browse the repository at this point in the history

  9. [groth16] add missing reference to CRS for 3-fac example

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    948f1bd View commit details
    Browse the repository at this point in the history

  10. [groth16] explicitly state g_1^C in proof sim equation

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a31e0ff View commit details
    Browse the repository at this point in the history

  11. fix labeling of [A2/5]g_1/2 eqs in align sections

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6e501dc View commit details
    Browse the repository at this point in the history

  12. fix references to g_1^A, ... eqs in prover example

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1d7bd38 View commit details
    Browse the repository at this point in the history

  13. clean up equations for [B]g_1, [B]g_2, one align for better alignment

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    238153b View commit details
    Browse the repository at this point in the history

  14. remove trailing line break in g_1^I eq

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5519c0e View commit details
    Browse the repository at this point in the history

  15. clean up eq ref, replace single eq in align -> equation

    @Vindaar
    Vindaar committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    4d79f1d View commit details
    Browse the repository at this point in the history