Labels: Can display labels in 3 formats #5

rasamimalala · 2019-01-03T08:18:04Z

Hi,
I've commited the following modification:

Add dmd option to show labels in Degrees - Decimal minutes instead of Decimal Degrees.
Modify labels placement to be more readable by users
Allow to specify fractional interval by adding precision option for Lat and Lon
Update docs

srappel

Wow this cleans up the formatting a lot! I like the text justified to the side of the lines. Decimal minutes makes more sense than trying to cram minutes and seconds in there like I was.

srappel

I'm still having a minor issue that when I scroll all the way to the west and reach the 180th meridian, the numbers to the west of it are labeled as W when they are in the Eastern Hemisphere. The same happens scrolling to 180 to the East.

…meridian

rasamimalala · 2019-01-10T08:00:19Z

I solved your minor issue. However, labelling is only working for longitude which are between -360 and 360 degrees.

IvanSanchez · 2019-01-11T22:28:06Z

Leaflet.Graticule.js

@@ -13,6 +13,8 @@ L.LatLngGraticule = L.Layer.extend({
        font: '12px Verdana',
        lngLineCurved: 0,
        latLineCurved: 0,
+        dmd: false, // Labels: Display Degrees - Decimal Minutes instead of Decimal Degrees


I would like a format options instead (with dmd as possible value) instead. There are more than 2 coordinate formats.

I'll put an option named format which can have one of the following values:

dd: Decimal Degrees (default value)

dmd: Degrees - Decimal Minutes

dms: Degrees - Minutes - Seconds

Leaflet.Graticule.js

IvanSanchez · 2019-01-11T22:30:42Z

Leaflet.Graticule.js

+        if (this.options.dmd) {
+            // todo: format type of float
+            if (lng > 180) {
+                return this.__deg_to_dmd(360 - lng) + ' W';


Use modulus 360 (i.e. lng % 360) instead.

Or better yet, use wrapLatLng() of the map's CRS. (i.e this._map.options.crs.warpLatLng(latlng)) on the appropriate place, or even this._map.options.crs.warpLatLng([0, lng]).lng. That should care of maps with non-default CRSs.

IvanSanchez · 2019-01-11T22:33:42Z

Leaflet.Graticule.js

@@ -419,7 +480,7 @@ L.LatLngGraticule = L.Layer.extend({
                    ctx.lineTo(rr.x-1, rr.y);
                    ctx.stroke();
                    if (self.options.showLabel && label) {
-                        var _yy = ll.y + (txtHeight/2)-2;
+                        var _yy = ll.y - (txtHeight/2) + 2;


Why this change? Seems unrelated at first sight.

This change is about labels placements.

IvanSanchez · 2019-01-11T22:33:50Z

Leaflet.Graticule.js

@@ -490,8 +551,8 @@ L.LatLngGraticule = L.Layer.extend({
                    ctx.stroke();

                    if (self.options.showLabel && label) {
-                        ctx.fillText(lngstr, tt.x - (txtWidth/2), txtHeight+1);
-                        ctx.fillText(lngstr, bb.x - (txtWidth/2), hh-3);
+                        ctx.fillText(lngstr, tt.x + 3, txtHeight+1);


Why this change? Seems unrelated at first sight.

This change is about labels placements.

rasamimalala · 2019-01-14T08:25:18Z

I make a new commit according to your changes request.

Can display Degrees - Decimal minutes

e15f94f

srappel reviewed Jan 4, 2019

View reviewed changes

Debug minor issue on W and E labelling when scrolling over the 180th …

13fe4f9

…meridian

rasamimalala mentioned this pull request Jan 10, 2019

Allow zoomInterval smaller than 0.5 #4

Open

IvanSanchez suggested changes Jan 11, 2019

View reviewed changes

Put format option for labeland modify the docs

8be88c2

rasamimalala changed the title ~~Labels: Can display labels in Degrees - Decimal minutes~~ Labels: Can display labels in 3 formats Jan 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Labels: Can display labels in 3 formats #5

Labels: Can display labels in 3 formats #5

rasamimalala commented Jan 3, 2019 •

edited

Loading

srappel left a comment

srappel left a comment

rasamimalala commented Jan 10, 2019 •

edited

Loading

IvanSanchez Jan 11, 2019

rasamimalala Jan 14, 2019 •

edited

Loading

IvanSanchez Jan 11, 2019

IvanSanchez Jan 11, 2019

rasamimalala Jan 14, 2019

IvanSanchez Jan 11, 2019

rasamimalala Jan 14, 2019

rasamimalala commented Jan 14, 2019 •

edited

Loading

Labels: Can display labels in 3 formats #5

Are you sure you want to change the base?

Labels: Can display labels in 3 formats #5

Conversation

rasamimalala commented Jan 3, 2019 • edited Loading

srappel left a comment

Choose a reason for hiding this comment

srappel left a comment

Choose a reason for hiding this comment

rasamimalala commented Jan 10, 2019 • edited Loading

IvanSanchez Jan 11, 2019

Choose a reason for hiding this comment

rasamimalala Jan 14, 2019 • edited Loading

Choose a reason for hiding this comment

IvanSanchez Jan 11, 2019

Choose a reason for hiding this comment

IvanSanchez Jan 11, 2019

Choose a reason for hiding this comment

rasamimalala Jan 14, 2019

Choose a reason for hiding this comment

IvanSanchez Jan 11, 2019

Choose a reason for hiding this comment

rasamimalala Jan 14, 2019

Choose a reason for hiding this comment

rasamimalala commented Jan 14, 2019 • edited Loading

rasamimalala commented Jan 3, 2019 •

edited

Loading

rasamimalala commented Jan 10, 2019 •

edited

Loading

rasamimalala Jan 14, 2019 •

edited

Loading

rasamimalala commented Jan 14, 2019 •

edited

Loading