refactor: aggregator uses flags instead of config-file

[0xpanicError]

Working on this issue: #57

Refactored the aggregator such that make start-aggregator uses flags instead of config-files for the following variables:

# 'production' only prints info and above. 'development' also prints debug
environment: production
eth_rpc_url: http://localhost:8545
eth_ws_url: ws://localhost:8545
# address which the aggregator listens on for operator signed messages
aggregator_server_ip_port_address: localhost:8090

Question: Should I delete the config-files/aggregator.yaml file ?

[samlaf]

Added a bunch of comments. I'll also run the tests so you an fix those, assuming they will be broken with these changes.

[samlaf]

set to not required and give default value of development

[samlaf]

I know this was the old variable name, but don't like it anymore. Can we separate into two separate flags, ListenHost and ListenPort? This makes it more obvious that ip can be a hostname, plus feel like separating them is more canonical from what I've seen.

Also you can make the default ListenHost 0.0.0.0

[0xpanicError]

So which one of them should I pass in config.AggregatorServerIpPortAddr ? If you want both to be passed then the config struct needs to be refactored which I think I could do in a different PR to reduce complexity. (as I would have to make changes in aggregator.go as well)

[samlaf]

remove this flag

[0xpanicError]

You mean move them from requiredFlags to optionalFlags

[samlaf]

we don't need to use configRaw anymore. Remove it.

[samlaf]

these feel like bugs. What if the ethRpcUrl is set to ""? You should probably return an error.

[samlaf]

This is going to get out of hands. Let's move the config variables to a .env file that users can source before running make commands. ALso this way we can have an anvil.env file and a holesky.env file, etc.

[samlaf]

Can you add EnvVar flags to these? See how eigenDA does it: https://github.com/Layr-Labs/eigenda/blob/e7ec7fa7f8dddda8fd64ec77435694d1c5dc9851/disperser/cmd/batcher/flags/flags.go#L25

[0xpanicError]

@samlaf looking at how eigenda implements flags, I think we can create a separate file for flags inside core/config given they're getting slightly large.