Add and check contract code formatting using forge fmt
#48
Conversation
There was a problem hiding this comment.
I forget why exactly but if you look closely the mock token is not just the default OZ erc20 contract.
It's got weird behavior like minting on transfers. I think this was so that we don't need to approve or something... might be wrong. But I fear merging this will prob break some thing. :\
There was a problem hiding this comment.
I mean the tests seem to pass, but looking at it the old transferFrom function it didn't check the allowance vs. the standard OZ token which will. Just changed that, should be good.
There was a problem hiding this comment.
Main problem is that I don't trust the tests in here :|
Do you mind removing this ERC20Mock changes from this PR, and let's make a separate one from that where we actually use the standard OZ token like you were proposing. Created this issue for it: #49
Also just merged #46 so you'll need to rebase your branch on top of master... sorry about that :(
PR also includes some other minor clean-up like simplifying the mock token and making imports explicit for the non-script contracts.