Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add eigenpod write methods #314

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

feat: add eigenpod write methods #314

wants to merge 2 commits into from

Conversation

shrimalmadhur
Copy link
Collaborator

Fixes # .

What Changed?

  • Add VerifyWithdrawalCredentials to eigenpod writer

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@shrimalmadhur shrimalmadhur changed the title feat: add verify credentials for eigenpod feat: add eigenpod write methods Aug 5, 2024
@shrimalmadhur shrimalmadhur requested review from samlaf and removed request for samlaf August 5, 2024 23:47
samlaf
samlaf approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let one comment but not that important.

chainio/clients/eigenpod/writer.go
stateRootProof bindings.BeaconChainProofsStateRootProof,
validatorIndices []*big.Int,
validatorFieldsProofs [][]byte,
validatorFields [][][32]byte,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nice to document what this is. Or define named types for self-documenting code.

@shrimalmadhur shrimalmadhur marked this pull request as draft September 11, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrimalmadhur @samlaf