Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check bindings github workflow #264

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

samlaf
Copy link
Collaborator

@samlaf samlaf commented Jun 9, 2024

Fixes # .

What Changed?

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@samlaf samlaf marked this pull request as draft June 9, 2024 08:31
@samlaf
Copy link
Collaborator Author

samlaf commented Jun 9, 2024

dockerized fork of abigen is now biting me back in the ass hehe.
image
Not sure why file is being recreated without read permission...
Workflow run also taking 4m to run now...

TODO:

  • figure out how to fix the read permission
  • remove the docker image building inside make bindings script (see here), just build it once, push it to ghcr, and then use that inside the workflow (should be faster than building it every run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant