Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: inheritdoc #775

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: inheritdoc #775

wants to merge 1 commit into from
+68 −370

Conversation

0xClandestine
Copy link
Contributor

No description provided.

@0xClandestine
Copy link
Contributor Author

Not currently compiling, we're missing interface definitions for many functions...

ypatil12
ypatil12 reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we validate the natspec in the interface matches what we remove? IIRC some of these do not align properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypatil12 ypatil12 ypatil12 left review comments

@gpsanant gpsanant Awaiting requested review from gpsanant

@wadealexc wadealexc Awaiting requested review from wadealexc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xClandestine @ypatil12