Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the need of ecdsa key by default #120

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

shrimalmadhur
Copy link
Contributor

@shrimalmadhur shrimalmadhur commented Apr 24, 2024

  • This PR removes the need of ECDSA key while running the node by default. Operator can still choose to use but there will be extra steps required and would generally be not recommended

This PR also changes interfaces for all operations.

Note: Same .env file is being used for these operations and running node. Even though only few variables are needed from the .env files for run.sh script, to have minimal change I want to keep .env for this too. But this is debatable if we want to remove .env file for run.sh we have to make everything as argument and also need to make sure nodeplugin doesn't require any unnecessary fields from .env file

Opt In

./run.sh \
  --operation-type opt-in \
  --node-ecdsa-key-file-host /path/to/ecdsa/file  \
  --node-ecdsa-key-password password \
  --quorums 0

Opt out

./run.sh \
  --operation-type opt-out \
  --node-ecdsa-key-file-host /path/to/ecdsa/file  \
  --node-ecdsa-key-password password \
  --quorums 0

List Quorums

./run.sh --operation-type list-quorums

Update socket

./run.sh \
  --operation-type update-socket \
  --node-ecdsa-key-file-host /path/to/ecdsa/file  \
  --node-ecdsa-key-password password

TODO

holesky/.env.example Outdated Show resolved Hide resolved
holesky/run.sh Show resolved Hide resolved
holesky/.env.example Outdated Show resolved Hide resolved
holesky/.env.example Outdated Show resolved Hide resolved
@@ -89,13 +94,15 @@ NODE_DB_PATH_HOST=${EIGENDA_HOME}/db
NODE_CACHE_PATH_HOST=${USER_HOME}/eigenda-operator-setup/resources/cache

# TODO: Operators need to update this to their own keys
NODE_ECDSA_KEY_FILE_HOST=${EIGENLAYER_HOME}/operator_keys/opr.ecdsa.key.json
# Uncomment NODE_ECDSA_KEY_FILE_HOST if your need access to ecdsa key. This is generally not recommended
# NODE_ECDSA_KEY_FILE_HOST=${EIGENLAYER_HOME}/operator_keys/opr.ecdsa.key.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still generate this key in EigenLayer cli by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default we don't generate any key - they can generate or not but - it's not them.

holesky/run.sh Outdated Show resolved Hide resolved
holesky/run.sh Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants