Port Personality Provider from Lawnchair Legacy #4848
Conversation
…bizzare adventure !!!
lawnchair/src/app/lawnchair/smartspace/model/SmartspaceScores.kt
Outdated
Show resolved
Hide resolved
lawnchair/src/app/lawnchair/smartspace/provider/SmartspaceProvider.kt
Outdated
Show resolved
Hide resolved
lawnchair/src/app/lawnchair/smartspace/provider/PersonalityProvider.kt
Outdated
Show resolved
Hide resolved
lawnchair/src/app/lawnchair/smartspace/provider/PersonalityProvider.kt
Outdated
Show resolved
Hide resolved
lawnchair/src/app/lawnchair/smartspace/provider/PersonalityProvider.kt
Outdated
Show resolved
Hide resolved
lawnchair/src/app/lawnchair/smartspace/provider/PersonalityProvider.kt
Outdated
Show resolved
Hide resolved
lawnchair/src/app/lawnchair/smartspace/provider/PersonalityProvider.kt
Outdated
Show resolved
Hide resolved
lawnchair/src/app/lawnchair/smartspace/provider/PersonalityProvider.kt
Outdated
Show resolved
Hide resolved
| <!-- Personality provider --> | ||
| <string name="personality_provider">Contextual messages</string> | ||
| <string-array name="smartspace_personality_greetings_morning"> | ||
| <item>Good morning!</item> | ||
| <item>Have a great day!</item> | ||
| <item>It’s a beautiful day outside!</item> | ||
| <item>Rise and shine!</item> | ||
| <item>Top of the morning to you!</item> | ||
| <item>Ready to start the day?</item> | ||
| </string-array> | ||
| <string-array name="smartspace_personality_greetings_morning_subtitles"> | ||
| <item>Wishing you a pleasant start to your day.</item> | ||
| <item>May your day be filled with joy and success.</item> | ||
| <item>Don\'t forget to enjoy the sunshine and fresh air.</item> | ||
| <item>Time to wake up and make things happen!</item> | ||
| <item>A cheerful greeting for a cheerful morning.</item> | ||
| <item>Let\'s make today amazing!</item> | ||
| </string-array> | ||
| <string-array name="smartspace_personality_greetings_evening"> | ||
| <item>What’s up?</item> | ||
| <item>Good evening!</item> | ||
| <item>How did your day go?</item> | ||
| <item>How was your day?</item> | ||
| <item>Evening! How are you?</item> | ||
| <item>Hope you had a good day!</item> | ||
| </string-array> | ||
| <string-array name="smartspace_personality_greetings_evening_subtitles"> | ||
| <item>Just checking in to see how your evening is going.</item> | ||
| <item>Curious to hear about your day\'s adventures.</item> | ||
| <item>Hoping your day was productive and fulfilling.</item> | ||
| <item>A friendly greeting for a wonderful evening.</item> | ||
| <item>Time to unwind and enjoy the rest of your day.</item> | ||
| </string-array> | ||
| <string-array name="smartspace_personality_greetings_night"> | ||
| <item>Sleep well!</item> | ||
| <item>See you tomorrow!</item> | ||
| <item>Good night!</item> | ||
| <item>Don’t stay up too late!</item> | ||
| <item>Night night!</item> | ||
| <item>Sweet dreams!</item> | ||
| </string-array> | ||
| <string-array name="smartspace_personality_greetings_night_subtitles"> | ||
| <item>May you have a restful sleep.</item> | ||
| <item>Looking forward to seeing you again tomorrow.</item> | ||
| <item>Wishing you a peaceful and pleasant night.</item> | ||
| <item>Remember to sleep for your health.</item> | ||
| <item>A cozy goodnight message for a sweet slumber.</item> | ||
| <item>May your dreams be filled with wonder and joy.</item> | ||
| </string-array> |
There was a problem hiding this comment.
Please help this is so robotic
There was a problem hiding this comment.
I haven't used old lawnchair, but this just shows greetings, right?
In my app I use ones from crdroid: https://raw.githubusercontent.com/crdroidandroid/android_packages_apps_Launcher3/14.0/res/values/cr_strings.xml (those starting with quickspace_grt_). I think bananadroid had some nice ones too.
There was a problem hiding this comment.
you can take greetings from the following
https://github.com/BananaDroid-Revived/android_packages_apps_Launcher3/blob/14/res/values/banana_strings.xml
https://github.com/BootleggersROM/packages_apps_Launcher3/blob/tirimbino/res/values/bootleg_strings.xml
https://github.com/ProjectMatrixx/android_packages_apps_Launcher3/blob/14.0/res/values/cr_strings.xml
There was a problem hiding this comment.
Thanks, will look into it.
There was a problem hiding this comment.
Maybe a bad idea, but how about a small ML model to provide greetings?
validcube
changed the title
lawnchair/src/app/lawnchair/smartspace/model/SmartspaceScores.kt
Outdated
Show resolved
Hide resolved
|
Damn thanks for such a pr I wanted this so bad, but is it working ? I imported the changes on my fork but it doesn't seem to work Edit : it seems to have bugged the at a glance now it isnt visible |
|
|
|
Thanks for this PR, will review this after launcher3 A15 successfully buildable |
👋 Thanks for the feedback, I can reproduce this on my end, I'll try to find out what happened. Will draft the PR for now. The At a Glance widget supposed to be like this I can't upload the image on GitHub mobile so right now, you can have the “Error while uploading Screenshot_20240924_035703_Lawnchair (Debug).png” |
I ported three, tested one, was planning to do it during hacktoberfest, but nevermind, i'm too excited.
Description
I know, my priority suck, I'm finishing #4500 after this
Type of change
❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
✅ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)