Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bgfx demo #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix bgfx demo #55

wants to merge 1 commit into from

Conversation

Protoxy22
Copy link

@Protoxy22 Protoxy22 commented Jun 8, 2024

I'm not 100% sure about the code, but at least the bgfx demo works again (tested on Windows)

@Spasi
Copy link
Member

Spasi commented Jun 9, 2024

Hey @Protoxy22,

Thanks for the patch! The new code is fine and the old code is indeed not working. However, it looks like there's a relative recent bgfx bug that broke it:

bkaradzic/bgfx@72cbe83#diff-75ed10dd2a2698c8707c9c9750ec40b3d12bbdf747f0c18514ed89caa3b2c522L1881

Should have kept the other memCopy, that copies from g_platformData to m_init.platformData. I'm currently building bgfx with a fix, it will be available in the next 3.3.4 snapshot.

@Spasi
Copy link
Member

Spasi commented Jun 9, 2024

Ended up with a different fix, but I can verify that the issue is resolved with the latest bgfx build and the original code. You can download the fixed build from https://www.lwjgl.org/browse/nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants