Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to get PFA to work with latest AMS. #39

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

tpatki
Copy link
Member

@tpatki tpatki commented Jan 18, 2024

Based on the debugging session from Jan 17, 2024.

We updated CMakeLists.txt to use list (APPEND ... instead of the previous add_library, as that was causing linking errors.
Also updated eos_ams.cpp to have the PFA annotation after the template is defined.

@koparasy koparasy self-requested a review January 22, 2024 16:45
Copy link
Member

@koparasy koparasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@koparasy koparasy merged commit 3e3d6ee into LLNL:develop Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants