Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-arrange some tests #41

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Re-arrange some tests #41

merged 1 commit into from
Aug 2, 2024

Conversation

michaelklishin
Copy link
Collaborator

There are no functional changes in this PR.

The changes to tests are the following.

  • Some suite names ended in "test" and others in "tests", let's use "tests" across the board since there are multiple tests per suite
  • RHS substitution tests now have their own suite because it is a pretty isolated feature
  • Some in-module EUnit tests were left alone because they depend on internal functions and, perhaps, that's exactly why they were added as "in-module" EUnit tests
  • RHS substitution tests did not really have a happy path case, so I've added one

 * Some suite names ended in "test" and others in "tests",
   let's use "tests" across the board since there are
   multiple tests per suite
 * RHS substitution tests now have their own suite
   because it is a pretty isolated feature
 * Some in-module EUnit tests were left alone because
   they depend on internal functions and, perhaps,
   that's exactly why they were added as "in-module"
   EUnit tests
 * RHS substitution tests did not really have
   a happy path case, so I've added one
@michaelklishin michaelklishin added this to the 3.3.0 milestone Aug 2, 2024
@michaelklishin michaelklishin merged commit 65c1e02 into master Aug 2, 2024
6 checks passed
@michaelklishin michaelklishin deleted the mk-reorganize-some-tests branch August 2, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant