Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a custom content provider that can download icons #1449

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

brudaswen
Copy link

@brudaswen brudaswen commented Nov 27, 2022

Added a way to load icons from Web and from apps installed on device.

In order to not require the INTERNET permission and to not bloat KeePassDX itself with this logic, a new helper app has been created that does all the heavy lifting related to the icon loading and parsing. Currently, DuckDuckGo and Google is used to search for icons of the given URLs.

The data is exposed via a custom ContentProvider that KeePassDX queries to show a list of related icons that can be imported into the database.

I tried to keep the changes in the app to a minimum, but it required some changes in order to propagate the URLs and AndroidApp fields into the IconPicker such that it can query the content provider with this information.

Closes #596

Example entry with URLs and AndroidApps Loaded Icons
Screenshot_20221127-212826 Screenshot_20221127-212843

@J-Jamet J-Jamet added the feature label Dec 3, 2022
@J-Jamet
Copy link
Member

J-Jamet commented Dec 3, 2022

Thanks, it looks like a clean solution. I will test and look at the code in more detail when I have time, the content provider solution is a very good idea.

@brudaswen
Copy link
Author

@J-Jamet Did you have time to take a look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do
Development

Successfully merging this pull request may close these issues.

2 participants