KEEP for custom equals in inline classes #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilmirus
requested changes
Dec 20, 2022
| } | ||
| ``` | ||
|
|
||
| Type of `other` will be erased during compilation and passing argument will not require boxing. |
|
|
||
| More precise, we define typed equals as a function such that: | ||
|
|
||
| * Has name `"equals"` |
There was a problem hiding this comment.
Better to make examples conform the restrictions. For example, the one above does not have the annotation.
| ### Inline classes over inline classes | ||
|
|
||
| Suppose we have an inline class `B` over inline class `A` and `A` declares typed equals. In this case, | ||
| default-generated equals in `B` will be comparing it underlying values using custom equals of `A`. |
There was a problem hiding this comment.
Sure. Any usage of A will require opt-in and B will use A in its primary constructor declaration
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object other) { |
There was a problem hiding this comment.
First, this equals does not follow its contract. Second, how typed equals will be compiled into Valhalla class method?
|
|
||
| ### Resolving references to typed equals in compiler frontend | ||
|
|
||
| Currently `'=='` operator is being resolved to typed equals in compiler backend, but resolving it in frontend could let |
There was a problem hiding this comment.
Current decision is that == is never resolved on front-end, but IDE makes everything it can to resolve it. So, it is not about FE support, but rather IDE one.
added 5 commits
December 20, 2022 13:36
ilmirus
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.