-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gui): added a new feature to support multiple domains for gui. #13664
base: master
Are you sure you want to change the base?
Conversation
3f33864
to
f69a166
Compare
f69a166
to
320ce3d
Compare
320ce3d
to
120a41d
Compare
4d8e372
to
9dea7d9
Compare
9dea7d9
to
67f9d5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort. Let's decide the optimal way to implement this feature before going deep into this.
kong.conf.default
Outdated
# | ||
# `<scheme>://<IP / HOSTNAME>(:<PORT>)` | ||
# `<scheme>://<IP / HOSTNAME>[:PORT/PATH][, <scheme>://<IP / HOSTNAME>:PORT/PATH]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<scheme>://<IP / HOSTNAME>[:<PORT>][<PATH>][, <scheme>://<IP / HOSTNAME>[:<PORT>][<PATH>]]
Summary
admin_gui_url
has more than one domain, the origin from the request header must match one of theadmin_gui_url
. Otherwise, It can't access the Admin API via the Kong Manager.For example:
admin_gui_url=http://example.com,http://km.konghq.com/manager
These addresses access Kong Manager works well. http://example.com and http://km.konghq.com/manager.
Others can't.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KM-516