Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Add additional warning on debug-request #7949

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Oyami-Srk
Copy link
Member

@Oyami-Srk Oyami-Srk commented Sep 20, 2024

Description

Add a special note for the request debug feature to mention that request debug is not authenticated with X-Request-Debug-Token when requests are originating from loopback.

Testing instructions

Preview link:

Checklist

KAG-5418

@Oyami-Srk Oyami-Srk requested a review from a team as a code owner September 20, 2024 06:14
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 2e5cf1e
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66ed13d8198e590008ac317b
😎 Deploy Preview https://deploy-preview-7949--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 92 (🟢 up 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Oyami-Srk Oyami-Srk added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Sep 20, 2024
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this update!

@cloudjumpercat cloudjumpercat merged commit a6be66d into main Sep 20, 2024
15 checks passed
@cloudjumpercat cloudjumpercat deleted the pre-request-debugger-warning branch September 20, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants