Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add introduction of --disable-consumer-sync in konnect KIC section #7898

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Sep 11, 2024

Description

Add introduction of --disable-consumer-sync CLI argument to speedup KIC's synchronization of configurations to Konnect when there are a lot of consumers.
Fixes Kong/kubernetes-ingress-controller#6319.

Testing instructions

Preview link:

Checklist

@randmonkey randmonkey requested a review from a team as a code owner September 11, 2024 09:29
@randmonkey randmonkey self-assigned this Sep 11, 2024
@randmonkey randmonkey added the Kubernetes Team Kubernetes task tracking (including KIC) label Sep 11, 2024
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 63d201f
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66f475cac4b51d0008e60aa6
😎 Deploy Preview https://deploy-preview-7898--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93 (🟢 up 3 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@randmonkey randmonkey added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Sep 11, 2024
@randmonkey randmonkey force-pushed the kic/add_disable_kong_consumer_sync branch from 452eaca to 445308f Compare September 11, 2024 09:51
app/konnect/gateway-manager/kic.md Outdated Show resolved Hide resolved
app/konnect/gateway-manager/kic.md Show resolved Hide resolved
app/konnect/gateway-manager/kic.md Show resolved Hide resolved
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - sorry for breaking things, didn't realize this was a Konnect doc at first.

@lena-larionova
Copy link
Contributor

Looks like --disable-consumer-sync is missing from the table that you linked to: https://deploy-preview-7898--kongdocs.netlify.app/kubernetes-ingress-controller/latest/reference/cli-arguments/

@randmonkey randmonkey merged commit e1b19ac into main Sep 26, 2024
15 checks passed
@randmonkey randmonkey deleted the kic/add_disable_kong_consumer_sync branch September 26, 2024 02:18
@lmilan lmilan changed the title add introduction of --disable-consumer-sync in konnect KIC section Feat: add introduction of --disable-consumer-sync in konnect KIC section Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kubernetes Team Kubernetes task tracking (including KIC) review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the new flag --disable-consumer-sync in the konnect section
2 participants