-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Plugin examples #7327
Feat: Plugin examples #7327
Conversation
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Can we keep |
That makes sense to me. What about prereqs? |
I would keep pre_reqs in a separate list too, it gives us more flexibility |
@fabianrbz done. Kept the label short as |
app/assets/hub/kong-inc/rate-limiting-advanced/fixed-window-1.yaml
Outdated
Show resolved
Hide resolved
app/assets/hub/kong-inc/rate-limiting-advanced/silding-window-1.yaml
Outdated
Show resolved
Hide resolved
app/assets/hub/kong-inc/rate-limiting-advanced/sliding-window-2.yaml
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,9 @@ | |||
description: | | |||
Maximum of 100 requests every rolling hour, continuously adjusting the count over the course of the hour. No hard limit or known reset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a concrete example to help understand what this means? e.g.
- Consumer sends X requests in Y minutes
- Something happend
- Y minutes pass, something resets
- Consumer can make more requests
241ae4d
to
6d466a4
Compare
Description
Add hub examples directory with some existing examples for openId connect, HTTP Log, and AI Proxy (three plugins that I knew had useable examples).
https://konghq.atlassian.net/browse/DOCU-3835
Notes:
app/assets/hub/kong-inc
to mimic the pattern that KIC and KGO use for their examples. Does that work?@fabianrbz For the prereqs and customizable values, is it fine to just have them manually written in the description? Or would it be better to do something like this, in case the various bits have to get pulled into a layout separately:
Maybe that's a question for Carl & whoever implements the frontend eventually.
Testing instructions
Preview link:
Checklist