Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add two missing OTEL images to Kong Mesh docs #7268

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

cloudjumpercat
Copy link
Contributor

Description

There were two missing images from a Kuma doc that was shared in Kong Mesh. The link checker caught one (https://github.com/Kong/docs.konghq.com/actions/runs/8677190800/job/23792517751), but I added both to our site.

Testing instructions

Preview link:

Checklist

For example, if this change is for an upcoming 3.6 release, enclose your content in {% if_version gte:3.6.x %} <content> {% endif_version %} tags (or if_plugin_version tags for plugins).

Use any of the following keys:

  • gte:<version> - greater than or equal to a specific version
  • lte:<version> - less than or equal to a specific version
  • eq:<version> - exactly equal to a specific version

You can do the same for older versions.

@cloudjumpercat cloudjumpercat added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Apr 19, 2024
@cloudjumpercat cloudjumpercat requested a review from a team as a code owner April 19, 2024 16:47
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 9428138
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/6622a01bc10a570008e542a9
😎 Deploy Preview https://deploy-preview-7268--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 96 (🟢 up 6 from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudjumpercat cloudjumpercat merged commit fceb80e into main Apr 19, 2024
21 of 23 checks passed
@cloudjumpercat cloudjumpercat deleted the fix/mesh-otel-grafana-image branch April 19, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants