-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud gateway: Add Insomnia link, and set max-width to overview page #7240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guaris
added
the
review:general
Review for general accuracy and presentation. Does the doc work? Does it output correctly?
label
Apr 15, 2024
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
acgoldsmith
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Guaris
added a commit
that referenced
this pull request
Apr 16, 2024
* Feat: Cloud Gateways network and peering information (#7092) * peering information * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Update app/konnect/network-resiliency.md Co-authored-by: Diana <[email protected]> --------- Co-authored-by: Diana <[email protected]> * Feat: Cloud Gateways supported regions (#7110) * add new geos * Update app/konnect/geo.md Co-authored-by: lena-larionova <[email protected]> --------- Co-authored-by: lena-larionova <[email protected]> * feat: Cloud Gateway terminology updates (#7093) * Update konnect overview terms * Add more term updates for fully-managed data planes Signed-off-by: Diana <[email protected]> * Appease Vale Signed-off-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: Angel <[email protected]> Co-authored-by: lena-larionova <[email protected]> * Apply more copyedits Signed-off-by: Diana <[email protected]> * Rewrite some of the data plane node info to omit management style if it doesn't matter in that context Signed-off-by: Diana <[email protected]> --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Angel <[email protected]> Co-authored-by: lena-larionova <[email protected]> * Cloud gateways: How to upgrade data plane nodes (#7155) * Add Upgrade information for cloud gateways * api-key -> bearer * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * updates * vale --------- Co-authored-by: Diana <[email protected]> * Cloud Gateways: Custom DNS management (#7163) * Add dns instructions * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * Apply suggestions from code review Co-authored-by: Diana <[email protected]> --------- Co-authored-by: lena-larionova <[email protected]> Co-authored-by: Diana <[email protected]> * feat: Dedicated cloud gateway overview and changelog (#7084) * Start drafting overview page and add cloud gateway section to nav Signed-off-by: Diana <[email protected]> * Add release note, continue revising overview page text Signed-off-by: Diana <[email protected]> * Add diagram for cloud gateway and clean up some text Signed-off-by: Diana <[email protected]> * Fix diagram description and name of architecture heading Signed-off-by: Diana <[email protected]> * Add dashboard screenshot, additional revisions before SME review Signed-off-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: Angel <[email protected]> * More small updates Signed-off-by: Diana <[email protected]> * Fix the Vale error link by linking to the product instead Signed-off-by: Diana <[email protected]> * Move dedicated cloud gateways page to the intro section Signed-off-by: Diana <[email protected]> * Make feature list into a table, fix broken link in release note Signed-off-by: Diana <[email protected]> * Remove screenshot in favor of diagram, make feature table a use case/benefit table, clean up some of the text Signed-off-by: Diana <[email protected]> * Apply suggestions from code review * Add more images, add more content about how it works and how security works Signed-off-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * Fix broken image, apply copyedits Signed-off-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: Angel <[email protected]> * Apply suggestions from code review Co-authored-by: Angel <[email protected]> * Move CGW table, appease Vale Signed-off-by: Diana <[email protected]> --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Angel <[email protected]> Co-authored-by: lena-larionova <[email protected]> * Feat: Update get started with Konnect and transit gateway documentation (#7151) * Getting started, transit gateways, small terminology edits * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Update app/konnect/gateway-manager/data-plane-nodes/transit-gateways.md * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> --------- Co-authored-by: Diana <[email protected]> Co-authored-by: lena-larionova <[email protected]> * Cloud Gateways: Update troubleshooting section (#7197) * Troubleshooting info * organize * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * add navtab * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> --------- Co-authored-by: lena-larionova <[email protected]> * feat: Cloud Gateway operations (#7156) * Create provisioning page, add to nav, start filling out UI instructions Signed-off-by: Diana <[email protected]> * Add UI instructions for scaling, add link for upgrades info, start adding some API instructions Signed-off-by: Diana <[email protected]> * Continue adding API commands Signed-off-by: Diana <[email protected]> * Fix API instruction text, clean up content Signed-off-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * Adjust API instruction formatting and some grammar fixes Signed-off-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * Fix region placeholder notation, add role prereqs, revise some text Signed-off-by: Diana <[email protected]> * Add predicted API spec links, fix wording of configure mode Signed-off-by: Diana <[email protected]> --------- Signed-off-by: Diana <[email protected]> Co-authored-by: lena-larionova <[email protected]> * Update: Diagrams for cloud gateways (#7217) update diagrams for cloud gateways * Update: Plugin compatibility in dedicated cloud gateways (#7216) * plugin compatibility in cloud gateways * vale * relative urls * Update app/_hub/kong-inc/aws-lambda/_metadata/_index.yml Co-authored-by: Diana <[email protected]> * Update app/hub/plugins/compatibility/index.md --------- Co-authored-by: Angel <[email protected]> Co-authored-by: Diana <[email protected]> * Cloud Gateways: Chore PR (#7207) * Rewording, links, API specs * links * Resize picture, move overview page * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * Update app/konnect/index.md * remove soc 1 compliance statement * Fix links to dedicated cloud gateway page, update data plane node table to include self-managed Signed-off-by: Diana <[email protected]> * Update app/konnect/geo.md Co-authored-by: lena-larionova <[email protected]> --------- Signed-off-by: Diana <[email protected]> Co-authored-by: lena-larionova <[email protected]> Co-authored-by: Diana <[email protected]> * Chore: Update diagrams with "fully-managed" terminology (#7221) apply fully-managed terminology across diagrams * Cloud Gateways terminology (#7224) * terminology * stray a * Feat: Cloud gateways networking diagram (#7226) * cloud gateways networking diagram * fix typos * set the include to cached * move diagram to transit gateways page * Cloud gateway: Add Insomnia link, and set max-width to overview page (#7240) * api and image resize * fix id and link * Reword autopilot mode in overview page Co-authored-by: Amy Goldsmith <[email protected]> * broken links --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]> Co-authored-by: lena-larionova <[email protected]> Co-authored-by: Amy Goldsmith <[email protected]>
mheap
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Feat: Cloud Gateways network and peering information (#7092) * peering information * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Update app/konnect/network-resiliency.md Co-authored-by: Diana <[email protected]> --------- Co-authored-by: Diana <[email protected]> * Feat: Cloud Gateways supported regions (#7110) * add new geos * Update app/konnect/geo.md Co-authored-by: lena-larionova <[email protected]> --------- Co-authored-by: lena-larionova <[email protected]> * feat: Cloud Gateway terminology updates (#7093) * Update konnect overview terms * Add more term updates for fully-managed data planes Signed-off-by: Diana <[email protected]> * Appease Vale Signed-off-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: Angel <[email protected]> Co-authored-by: lena-larionova <[email protected]> * Apply more copyedits Signed-off-by: Diana <[email protected]> * Rewrite some of the data plane node info to omit management style if it doesn't matter in that context Signed-off-by: Diana <[email protected]> --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Angel <[email protected]> Co-authored-by: lena-larionova <[email protected]> * Cloud gateways: How to upgrade data plane nodes (#7155) * Add Upgrade information for cloud gateways * api-key -> bearer * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * updates * vale --------- Co-authored-by: Diana <[email protected]> * Cloud Gateways: Custom DNS management (#7163) * Add dns instructions * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * Apply suggestions from code review Co-authored-by: Diana <[email protected]> --------- Co-authored-by: lena-larionova <[email protected]> Co-authored-by: Diana <[email protected]> * feat: Dedicated cloud gateway overview and changelog (#7084) * Start drafting overview page and add cloud gateway section to nav Signed-off-by: Diana <[email protected]> * Add release note, continue revising overview page text Signed-off-by: Diana <[email protected]> * Add diagram for cloud gateway and clean up some text Signed-off-by: Diana <[email protected]> * Fix diagram description and name of architecture heading Signed-off-by: Diana <[email protected]> * Add dashboard screenshot, additional revisions before SME review Signed-off-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: Angel <[email protected]> * More small updates Signed-off-by: Diana <[email protected]> * Fix the Vale error link by linking to the product instead Signed-off-by: Diana <[email protected]> * Move dedicated cloud gateways page to the intro section Signed-off-by: Diana <[email protected]> * Make feature list into a table, fix broken link in release note Signed-off-by: Diana <[email protected]> * Remove screenshot in favor of diagram, make feature table a use case/benefit table, clean up some of the text Signed-off-by: Diana <[email protected]> * Apply suggestions from code review * Add more images, add more content about how it works and how security works Signed-off-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * Fix broken image, apply copyedits Signed-off-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: Angel <[email protected]> * Apply suggestions from code review Co-authored-by: Angel <[email protected]> * Move CGW table, appease Vale Signed-off-by: Diana <[email protected]> --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Angel <[email protected]> Co-authored-by: lena-larionova <[email protected]> * Feat: Update get started with Konnect and transit gateway documentation (#7151) * Getting started, transit gateways, small terminology edits * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Update app/konnect/gateway-manager/data-plane-nodes/transit-gateways.md * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> --------- Co-authored-by: Diana <[email protected]> Co-authored-by: lena-larionova <[email protected]> * Cloud Gateways: Update troubleshooting section (#7197) * Troubleshooting info * organize * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * add navtab * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> --------- Co-authored-by: lena-larionova <[email protected]> * feat: Cloud Gateway operations (#7156) * Create provisioning page, add to nav, start filling out UI instructions Signed-off-by: Diana <[email protected]> * Add UI instructions for scaling, add link for upgrades info, start adding some API instructions Signed-off-by: Diana <[email protected]> * Continue adding API commands Signed-off-by: Diana <[email protected]> * Fix API instruction text, clean up content Signed-off-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * Adjust API instruction formatting and some grammar fixes Signed-off-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * Fix region placeholder notation, add role prereqs, revise some text Signed-off-by: Diana <[email protected]> * Add predicted API spec links, fix wording of configure mode Signed-off-by: Diana <[email protected]> --------- Signed-off-by: Diana <[email protected]> Co-authored-by: lena-larionova <[email protected]> * Update: Diagrams for cloud gateways (#7217) update diagrams for cloud gateways * Update: Plugin compatibility in dedicated cloud gateways (#7216) * plugin compatibility in cloud gateways * vale * relative urls * Update app/_hub/kong-inc/aws-lambda/_metadata/_index.yml Co-authored-by: Diana <[email protected]> * Update app/hub/plugins/compatibility/index.md --------- Co-authored-by: Angel <[email protected]> Co-authored-by: Diana <[email protected]> * Cloud Gateways: Chore PR (#7207) * Rewording, links, API specs * links * Resize picture, move overview page * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * Update app/konnect/index.md * remove soc 1 compliance statement * Fix links to dedicated cloud gateway page, update data plane node table to include self-managed Signed-off-by: Diana <[email protected]> * Update app/konnect/geo.md Co-authored-by: lena-larionova <[email protected]> --------- Signed-off-by: Diana <[email protected]> Co-authored-by: lena-larionova <[email protected]> Co-authored-by: Diana <[email protected]> * Chore: Update diagrams with "fully-managed" terminology (#7221) apply fully-managed terminology across diagrams * Cloud Gateways terminology (#7224) * terminology * stray a * Feat: Cloud gateways networking diagram (#7226) * cloud gateways networking diagram * fix typos * set the include to cached * move diagram to transit gateways page * Cloud gateway: Add Insomnia link, and set max-width to overview page (#7240) * api and image resize * fix id and link * Reword autopilot mode in overview page Co-authored-by: Amy Goldsmith <[email protected]> * broken links --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]> Co-authored-by: lena-larionova <[email protected]> Co-authored-by: Amy Goldsmith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
review:general
Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Insomnia link, and set max-width to overview page