Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable banner for Kong Gateway user survey #7237

Merged
merged 6 commits into from
Apr 17, 2024

Conversation

lena-larionova
Copy link
Contributor

@lena-larionova lena-larionova commented Apr 15, 2024

Description

https://konghq.atlassian.net/browse/DOCU-3750

Testing instructions

Preview link: https://deploy-preview-7237--kongdocs.netlify.app/

Checklist

For example, if this change is for an upcoming 3.6 release, enclose your content in {% if_version gte:3.6.x %} <content> {% endif_version %} tags (or if_plugin_version tags for plugins).

Use any of the following keys:

  • gte:<version> - greater than or equal to a specific version
  • lte:<version> - less than or equal to a specific version
  • eq:<version> - exactly equal to a specific version

You can do the same for older versions.

@lena-larionova lena-larionova added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Apr 15, 2024
@lena-larionova lena-larionova requested a review from a team as a code owner April 15, 2024 17:45
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit a4545c7
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/661fdaa1aea42a00081e6cbc
😎 Deploy Preview https://deploy-preview-7237--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93 (🟢 up 2 from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Guaris Guaris added the do not merge Issues/ PRs whose changes should not be merged at this time label Apr 15, 2024
@Guaris Guaris marked this pull request as draft April 15, 2024 18:44
@Guaris
Copy link
Contributor

Guaris commented Apr 15, 2024

image

X floats here too far

@lena-larionova
Copy link
Contributor Author

X floats here too far

@Guaris weirdly enough, this is a "feature" of the design. I can't easily move this X; it's also defined purely in CSS, for some reason (not an icon).

@lena-larionova lena-larionova removed the do not merge Issues/ PRs whose changes should not be merged at this time label Apr 17, 2024
@lena-larionova lena-larionova marked this pull request as ready for review April 17, 2024 14:20
@lena-larionova lena-larionova merged commit d53fbc1 into main Apr 17, 2024
19 of 29 checks passed
@lena-larionova lena-larionova deleted the chore/survey-banner branch April 17, 2024 14:53
acgoldsmith added a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants