-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enable banner for Kong Gateway user survey #7237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lena-larionova
added
the
review:general
Review for general accuracy and presentation. Does the doc work? Does it output correctly?
label
Apr 15, 2024
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Guaris
approved these changes
Apr 15, 2024
Guaris
added
the
do not merge
Issues/ PRs whose changes should not be merged at this time
label
Apr 15, 2024
@Guaris weirdly enough, this is a "feature" of the design. I can't easily move this X; it's also defined purely in CSS, for some reason (not an icon). |
lena-larionova
removed
the
do not merge
Issues/ PRs whose changes should not be merged at this time
label
Apr 17, 2024
acgoldsmith
added a commit
that referenced
this pull request
May 17, 2024
This reverts commit d53fbc1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
review:general
Review for general accuracy and presentation. Does the doc work? Does it output correctly?
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://konghq.atlassian.net/browse/DOCU-3750
Testing instructions
Preview link: https://deploy-preview-7237--kongdocs.netlify.app/
Checklist
For example, if this change is for an upcoming 3.6 release, enclose your content in
{% if_version gte:3.6.x %} <content> {% endif_version %}
tags (orif_plugin_version
tags for plugins).Use any of the following keys:
gte:<version>
- greater than or equal to a specific versionlte:<version>
- less than or equal to a specific versioneq:<version>
- exactly equal to a specific versionYou can do the same for older versions.