Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) clarify OSS in install page #7235

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

acgoldsmith
Copy link
Contributor

@acgoldsmith acgoldsmith commented Apr 15, 2024

Description

More clarification on the OSS heading in the table, so it's crystal clear that the entire Kong platform doesn't offer OSS option. Based on discussion w/ Aghi over slack.

Testing instructions

Preview link:

Checklist

For example, if this change is for an upcoming 3.6 release, enclose your content in {% if_version gte:3.6.x %} <content> {% endif_version %} tags (or if_plugin_version tags for plugins).

Use any of the following keys:

  • gte:<version> - greater than or equal to a specific version
  • lte:<version> - less than or equal to a specific version
  • eq:<version> - exactly equal to a specific version

You can do the same for older versions.

@acgoldsmith acgoldsmith requested a review from a team as a code owner April 15, 2024 14:37
@acgoldsmith acgoldsmith added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Apr 15, 2024
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 0f77ad6
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/661d3bc0c04f3800083d7323
😎 Deploy Preview https://deploy-preview-7235--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@acgoldsmith acgoldsmith merged commit aa6d3fd into main Apr 15, 2024
21 of 23 checks passed
@acgoldsmith acgoldsmith deleted the acgoldsmith-install-feedbck-aghi branch April 15, 2024 14:45
mheap pushed a commit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants