Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(plugins): updates the description for app-reg #7120

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

raoxiaoyan
Copy link
Contributor

@raoxiaoyan raoxiaoyan commented Mar 22, 2024

Description

Testing instructions

Preview link:

Checklist

For example, if this change is for an upcoming 3.6 release, enclose your content in {% if_version gte:3.6.x %} <content> {% endif_version %} tags (or if_plugin_version tags for plugins).

Use any of the following keys:

  • gte:<version> - greater than or equal to a specific version
  • lte:<version> - less than or equal to a specific version
  • eq:<version> - exactly equal to a specific version

You can do the same for older versions.

FTI-5789
KM-47

@raoxiaoyan raoxiaoyan requested a review from a team as a code owner March 22, 2024 08:54
Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit e6b974c
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/6627f1b6c1af15000828502b
😎 Deploy Preview https://deploy-preview-7120--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93
Accessibility: 93
Best Practices: 98
SEO: 91
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@raoxiaoyan raoxiaoyan added the review:copyedit Request for writer review. label Mar 22, 2024
@raoxiaoyan
Copy link
Contributor Author

Please wait for this PR to be merged. https://github.com/Kong/kong-ee/pull/8556

@raoxiaoyan raoxiaoyan added this to the Gateway 3.7 milestone Mar 22, 2024
@lena-larionova lena-larionova self-assigned this Mar 22, 2024
@lena-larionova lena-larionova added the do not merge Issues/ PRs whose changes should not be merged at this time label Mar 22, 2024
@lena-larionova
Copy link
Contributor

lena-larionova commented Mar 22, 2024

Why is there development on the app registration plugin in 3.7, if we are no longer supporting the Dev Portal?

Got my answer in Slack. Adding this change is fine, we'll just need to make some adjustments to the plugin doc itself (outside the scope of this PR).

@raoxiaoyan
Copy link
Contributor Author

Why is there development on the app registration plugin in 3.7, if we are no longer supporting the Dev Portal?

Got my answer in Slack. Adding this change is fine, we'll just need to make some adjustments to the plugin doc itself (outside the scope of this PR).

Thanks. This PR will be backported to 3.4.x, 3.5.x, and 3.6.x.

@raoxiaoyan raoxiaoyan force-pushed the docs/FTI-5789 branch 4 times, most recently from 86b93ee to 1e8525e Compare March 29, 2024 06:18
@raoxiaoyan raoxiaoyan force-pushed the docs/FTI-5789 branch 2 times, most recently from a78aa34 to 260c995 Compare March 29, 2024 09:49
@raoxiaoyan raoxiaoyan requested a review from nekolab April 3, 2024 09:51
@sumimakito
Copy link
Member

Hello @lena-larionova - I've left some suggestions in the comments to describe these changes. Would you mind giving this PR another look? Thanks!

@lena-larionova lena-larionova added ci:manual-approve:link-validation do not merge Issues/ PRs whose changes should not be merged at this time and removed do not merge Issues/ PRs whose changes should not be merged at this time labels Apr 12, 2024
@lena-larionova
Copy link
Contributor

This LGTM now, but holding off to merge until it gets into a 3.4 patch. Our doc currently lists 3.4 as the last available version for the plugin.

@lena-larionova
Copy link
Contributor

lena-larionova commented Apr 19, 2024

Merge after https://github.com/Kong/kong-ee/pull/8746 gets merged + next 3.4 patch after that.

@lena-larionova lena-larionova mentioned this pull request Apr 22, 2024
2 tasks
@raoxiaoyan
Copy link
Contributor Author

Merge after Kong/kong-ee#8746 gets merged + next 3.4 patch after that.

@lena-larionova It is ready for merge.

@lena-larionova
Copy link
Contributor

Yep, I've marked this PR for release with the 3.4.3.7 patch. I'll merge when it goes out.

@lena-larionova lena-larionova merged commit 639151d into main Apr 23, 2024
15 checks passed
@lena-larionova lena-larionova deleted the docs/FTI-5789 branch April 23, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:manual-approve:link-validation do not merge Issues/ PRs whose changes should not be merged at this time review:copyedit Request for writer review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants