-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(plugins): updates the description for app-reg #7120
Conversation
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Please wait for this PR to be merged. https://github.com/Kong/kong-ee/pull/8556 |
Got my answer in Slack. Adding this change is fine, we'll just need to make some adjustments to the plugin doc itself (outside the scope of this PR). |
Thanks. This PR will be backported to 3.4.x, 3.5.x, and 3.6.x. |
86b93ee
to
1e8525e
Compare
a78aa34
to
260c995
Compare
Hello @lena-larionova - I've left some suggestions in the comments to describe these changes. Would you mind giving this PR another look? Thanks! |
260c995
to
80ebeeb
Compare
80ebeeb
to
f8dcb96
Compare
f8dcb96
to
68aa3cc
Compare
This LGTM now, but holding off to merge until it gets into a 3.4 patch. Our doc currently lists 3.4 as the last available version for the plugin. |
Merge after https://github.com/Kong/kong-ee/pull/8746 gets merged + next 3.4 patch after that. |
@lena-larionova It is ready for merge. |
Yep, I've marked this PR for release with the 3.4.3.7 patch. I'll merge when it goes out. |
Description
Testing instructions
Preview link:
Checklist
For example, if this change is for an upcoming 3.6 release, enclose your content in
{% if_version gte:3.6.x %} <content> {% endif_version %}
tags (orif_plugin_version
tags for plugins).Use any of the following keys:
gte:<version>
- greater than or equal to a specific versionlte:<version>
- less than or equal to a specific versioneq:<version>
- exactly equal to a specific versionYou can do the same for older versions.
FTI-5789
KM-47