Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ARM support to install-instructions-test #6795

Merged
merged 13 commits into from
Jan 23, 2024
Merged

Add ARM support to install-instructions-test #6795

merged 13 commits into from
Jan 23, 2024

Conversation

mheap
Copy link
Member

@mheap mheap commented Jan 22, 2024 •
edited
Loading

Description

Use qemu to add arm64 tests for the install pages using GH Actions.

Testing instructions

Preview link: N/A

Checklist

  • Review label added
  • PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

@mheap mheap added the review:tech Request for technical review on the docs platform or processes. label Jan 22, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 22, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 18e0916
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/65afd91286cc3d00086351a2
😎 Deploy Preview https://deploy-preview-6795--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 90 (🔴 down 3 from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mheap mheap marked this pull request as ready for review January 22, 2024 18:03
@mheap mheap requested a review from a team as a code owner January 22, 2024 18:03
@mheap mheap requested a review from fabianrbz January 22, 2024 18:03
@mheap
Copy link
Member Author

mheap commented Jan 23, 2024

@fabianrbz This is ready for review. Failing RHEL has been raised internally

fabianrbz
fabianrbz approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@fabianrbz fabianrbz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@mheap mheap merged commit 2d9d9c4 into main Jan 23, 2024
30 of 32 checks passed
@mheap mheap deleted the arm-install-tests branch January 23, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianrbz fabianrbz fabianrbz approved these changes

Assignees
No one assigned
Labels
ci:manual-approve:link-validation review:tech Request for technical review on the docs platform or processes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mheap @fabianrbz