Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nadro/adhoc/revolve api improvement #3907

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nadr0
Copy link
Contributor

@nadr0 nadr0 commented Sep 17, 2024

relates #2540

  • -Z and Z are not allowed as revolve axis arguments. The revolve only happens on the local sketch plane of Y/-Y and X/-X.
  • Angle is defined by [0.0,360.0] (inclusive)
  • Added another sentence to clarify in the documentation that revolve happens around a local sketch axis and not a global axis

Copy link

qa-wolf bot commented Sep 17, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Sep 19, 2024 7:50pm

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.26%. Comparing base (0ff820d) to head (10c2254).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3907      +/-   ##
==========================================
- Coverage   87.28%   87.26%   -0.03%     
==========================================
  Files          69       69              
  Lines       25103    25118      +15     
==========================================
+ Hits        21911    21919       +8     
- Misses       3192     3199       +7     
Flag Coverage Δ
wasm-lib 87.26% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant